Modify operator hub tests to run in separate namespaces #3239

dharmit · 2020-05-22T09:29:44Z

What type of PR is this?
/kind cleanup
/kind failing-test

What does does this PR do / why we need it:
This PR ensures that each test spec for operator hub is run in a
separate namespace. This is needed because these tests were written in a
stringent fashion which tied the hands while writing additional tests
for the feature.

This PR should help take the tests out of the "odo test statistics"
dashboard.

Which issue(s) this PR fixes:

Fixes #3193

How to test changes / Special notes to the reviewer:

CI should pass. Specially for Operator Hub tests under
tests/integration/operatorhub.
Looks at the review comments I've made for clarification

dharmit · 2020-05-22T09:47:26Z

scripts/setup-operators.sh

@@ -28,9 +28,9 @@ install_etcd_operator(){
  kind: Subscription
  metadata:
    name: etcd
-    namespace: ${OPERATOR_HUB_PROJECT}
+    namespace: openshift-operators


Earlier, etcd operator was being installed in CI_OPERATOR_HUB_PROJECT and mongodb operator in openshift-operators. The way this was done made etcd operator available only in the CI_OPERATOR_HUB_PROJECT namespace while mongodb operator was available across the cluster.

Now, I have modified the code to install etcd operator across the cluster as well. The way this works is, we install it in openshift-operators namespace using clusterwide-alpha channel. This makes sure that the installed operator is available across all the namespaces on the cluster. Serves the purpose of both installing an operator in single namespce as well as across the cluster.

dharmit · 2020-05-22T09:48:31Z

tests/integration/operatorhub/cmd_service_test.go

+		ocArgs := []string{"get", "csv"}
+		helper.WaitForCmdOut("oc", ocArgs, 1, true, func(output string) bool {
+			return strings.Contains(output, "NAME")
+		}, true)


This wait is required because every time a user creates a new project, it takes OpenShift a few seconds before it can make the clusterwide operators available to the newly created namespace.

dharmit · 2020-05-22T09:48:57Z

tests/integration/operatorhub/cmd_service_test.go

+		ocArgs = []string{"get", "csv"}
+		helper.WaitForCmdOut("oc", ocArgs, 1, true, func(output string) bool {
+			return strings.Contains(output, "etcd")
+		}, true)


Same as https://github.com/openshift/odo/pull/3239/files#r429151204.

dharmit · 2020-05-22T09:49:15Z

tests/integration/operatorhub/cmd_service_test.go

+		ocArgs = []string{"get", "csv"}
+		helper.WaitForCmdOut("oc", ocArgs, 1, true, func(output string) bool {
+			return strings.Contains(output, "mongo")
+		}, true)


Same as https://github.com/openshift/odo/pull/3239/files#r429151204

dharmit · 2020-05-22T09:51:05Z

tests/integration/operatorhub/cmd_service_test.go

 		It("should only output the definition of the CR that will be used to start service", func() {
 			// First let's grab the etcd operator's name from "odo catalog list services" output
 			operators := helper.CmdShouldPass("odo", "catalog", "list", "services")
-			etcdOperator := regexp.MustCompile(`etcdoperator\.*[a-z][0-9]\.[0-9]\.[0-9]`).FindString(operators)
+			etcdOperator := regexp.MustCompile(`etcdoperator\.*[a-z][0-9]\.[0-9]\.[0-9]-clusterwide`).FindString(operators)


This modification is done because earlier when etcd operator was installed in a single namespace, output of odo catalog list services would be as below:

odo catalog list services Operators available in the cluster NAME CRDs etcdoperator.v0.9.4 EtcdCluster, EtcdBackup, EtcdRestore

But since it's now being installed from clusterwide channel, it looks like:

odo catalog list services Operators available in the cluster NAME CRDs etcdoperator.v0.9.4-clusterwide EtcdCluster, EtcdBackup, EtcdRestore

scripts/setup-operators.sh

tests/integration/operatorhub/cmd_service_test.go

prietyc123 · 2020-05-22T10:40:39Z

tests/integration/operatorhub/cmd_service_test.go

-				}
-			}
-			stdOut = strings.Join(lines, "\n")
-
 			// stdOut contains the yaml specification. Store it to a file
 			randomFileName := helper.RandString(6) + ".yaml"
 			fileName := filepath.Join("/tmp", randomFileName)


This won't work on windows. Please use context instead.

This is not a part of the PR.

Yes, I understood but It can be fixed right? It's not a big change that we can go for a new pr and review process. Anyway in the commit message you can mention the fix so that we can find out what this pr fixes.

I have not checked if it's a big change or a small one. Last time I tried to fix something in my PR that had not been touched in my PR, it ended up going for a really long time. So, if you think that this line of code is problematic, I humbly request you to open a new issue. But I'm not addressing it in this PR.

Issue has been tracked in #3246

prietyc123 · 2020-05-22T11:07:54Z

tests/integration/operatorhub/cmd_service_test.go

@@ -101,19 +153,19 @@ var _ = Describe("odo service command tests for OperatorHub", func() {
 			helper.CmdShouldPass("odo", "service", "create", "--from-file", fileName)

 			// now verify if the pods for the operator have started
-			pods := helper.CmdShouldPass("oc", "get", "pods", "-n", CI_OPERATOR_HUB_PROJECT)
+			pods := helper.CmdShouldPass("oc", "get", "pods", "-n", project)


As we are already setting project using odo command, There is no use of explicitly mentioning -n flag here. So I did just a check to confirm how odo project set sets active projects for oc too.

$ odo project create xya ✓ Project 'xya' is ready for use ✓ New project created and now using project: xya $ odo project list ACTIVE NAME default [...] viraj * xya $ oc projects You have access to the following projects and can switch between them with 'oc project <projectname>': default [...] viraj * xya $ odo project set viraj Switched to project : viraj $ odo project list ACTIVE NAME default [...] * viraj xya $ oc projects You have access to the following projects and can switch between them with 'oc project <projectname>': default [...] * viraj xya

I'm just being explicit here. Besides, in this comment #3193 (comment) you have mentioned to provide the project name for better user experience. So can you please decide if you want to use --project or not?

It seems you misunderstood my comment. NP, I have put the details in the issue what was trying to say.

As part of the --project flag is concerned TBH it depends on how you are going to use this. Here you have already setting the active project through odo project set... that too in justBeforeEach. So it really does not make sense to pass the --project flag in the spec implementation.

If you want to use the --project flag then don't use set command. Either way implementation will work fine.

It seems you misunderstood my comment. NP, I have put the details in the issue what was trying to say.

This comment thread which started from #3239 (comment) is about "not using the -n flag in tests", whereas that issue is about "project name not showing up in the output". How are the two things similar? How did I misunderstand what you were trying to say? What am I missing here? 🤔

As part of the --project flag is concerned TBH it depends on how you are going to use this. Here you have already setting the active project through odo project set... that too in justBeforeEach. So it really does not make sense to pass the --project flag in the spec implementation.

If you want to use the --project flag then don't use set command. Either way implementation will work fine.

This part of your comment is about what you started out with in #3239 (comment). But the issue and this comment thread don't seem to have anything in common !

tests/integration/operatorhub/cmd_service_test.go

prietyc123 · 2020-05-22T11:10:29Z

tests/integration/operatorhub/cmd_service_test.go


 			// Now let's check the output again to ensure expected behaviour
-			stdOut = helper.CmdShouldFail("odo", "service", "list")
-			jsonOut = helper.CmdShouldFail("odo", "service", "list", "-o", "json")
+			stdOut = helper.CmdShouldFail("odo", "service", "list", "--project", project)


Project has been set in preSetup, So calling it here through --project makes no sense to me. Please check the similar occurence throughout the changes.

#3239 (comment)

prietyc123 · 2020-05-22T11:11:42Z

Thanks @amitkrout for providing few inputs.

prietyc123 · 2020-05-22T11:12:27Z

tests/integration/operatorhub/cmd_service_test.go

-			stdOut = helper.CmdShouldFail("odo", "service", "list")
-			jsonOut = helper.CmdShouldFail("odo", "service", "list", "-o", "json")
+			stdOut = helper.CmdShouldFail("odo", "service", "list", "--project", project)
+			jsonOut = helper.CmdShouldFail("odo", "service", "list", "-o", "json", "--project", project)


#3239 (comment)

kadel · 2020-05-22T11:30:34Z

/approve

prietyc123 · 2020-05-22T13:47:27Z

tests/integration/operatorhub/cmd_service_test.go


-			stdOut = helper.CmdShouldPass("odo", "service", "list")
+			stdOut := helper.CmdShouldPass("odo", "service", "list")
 			Expect(stdOut).To(ContainSubstring("example"))
 			Expect(stdOut).To(ContainSubstring("EtcdCluster"))


Make it in a single check as you have done in https://github.com/openshift/odo/pull/3239/files#diff-49f09fb5341717455c0421b3c592e685R243

Not touched in this PR. Please open a separate issue for this to be addressed. I can't have double standards between this and #3239 (comment) even if I'm aware of the change that needs to be made. I'm sorry.

@dharmit Do you need a separate issue for this?

Issue #3245

dharmit · 2020-05-22T14:05:23Z

CI's failing in the Operator Hub tests. Looking into it. It works just fine locally. Not sure what's going wrong in the CI. 😞

dharmit · 2020-05-22T16:16:37Z

@amitkrout We're running all test spec in separate namespaces in this PR. I'm not sure why the CI is reporting below error. How did the service example exist before it was created? I'm likely missing something:

 [odo] I0522 12:57:46.421581    9777 preference.go:188] The path for preference file is /tmp/artifacts/.odo/preference.yaml
[odo] apiVersion: etcd.database.coreos.com/v1beta2
[odo] kind: EtcdCluster
[odo] metadata:
[odo]   annotations:
[odo]     etcd.database.coreos.com/scope: clusterwide
[odo]   name: example
[odo] spec:
[odo]   size: 3
[odo]   version: 3.2.13
[odo] 
Running odo with args [odo service create --from-file /tmp/gtlxka.yaml]
[odo] I0522 12:57:46.631585    9800 preference.go:188] The path for preference file is /tmp/artifacts/.odo/preference.yaml
[odo] I0522 12:57:46.631782    9800 preference.go:188] The path for preference file is /tmp/artifacts/.odo/preference.yaml
[odo] I0522 12:57:46.631990    9800 operators.go:17] Fetching list of operators installed in cluster
[odo] I0522 12:57:46.695813    9800 preference.go:188] The path for preference file is /tmp/artifacts/.odo/preference.yaml
[odo] Deploying service of type: EtcdCluster
[odo]  •  Deploying service  ...
[odo] I0522 12:57:46.696082    9800 preference.go:188] The path for preference file is /tmp/artifacts/.odo/preference.yaml
[odo]  ✗  Deploying service [32ms]
[odo]  ✗  etcdclusters.etcd.database.coreos.com "example" already exists
Deleting project: jcewwlhjsd
Running odo with args [odo project delete jcewwlhjsd -f]
[odo] I0522 12:57:47.038910    9818 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "jcewwlhjsd"
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo]  ✓  Deleted project : jcewwlhjsd
• Failure [15.530 seconds]
odo service command tests for OperatorHub
/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:17
  When using from-file option
  /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:122
    should be able to create a service [It]
    /go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:132
    No future change is possible.  Bailing out early after 0.305s.
      
    Running odo with args [odo service create --from-file /tmp/gtlxka.yaml]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /go/src/github.com/openshift/odo/tests/helper/helper_run.go:34

EDIT: Running with 1 ginkgo node works just fine:

$ git diff
diff --git a/Makefile b/Makefile
index 393fa6df2..a30986922 100644
--- a/Makefile
+++ b/Makefile
@@ -339,4 +339,4 @@ openshiftci-presubmit-unittests:
 # Run OperatorHub tests
 .PHONY: test-operator-hub
 test-operator-hub:
-       ginkgo $(GINKGO_FLAGS) -focus="odo service command tests" tests/integration/operatorhub/
+       ginkgo $(GINKGO_FLAGS_SERIAL) -focus="odo service command tests" tests/integration/operatorhub/

$ make test-operator-hub
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=1 -focus="odo service command tests" tests/integration/operatorhub/
Running Suite: Operatorhub Suite
================================
Random Seed: 1590164302 - Will randomize all specs
Will run 7 of 7 specs

•••••••
Ran 7 of 7 Specs in 207.982 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 3m28.74751566s
Test Suite Passed

$ make test-operator-hub
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=1 -focus="odo service command tests" tests/integration/operatorhub/
Running Suite: Operatorhub Suite
================================
Random Seed: 1590164608 - Will randomize all specs
Will run 7 of 7 specs

•••••••
Ran 7 of 7 Specs in 251.653 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 4m12.499072613s
Test Suite Passed

amitkrout · 2020-05-26T06:40:56Z

How did the service example exist before it was created? I'm likely missing something:

Checking

amitkrout · 2020-05-26T07:34:07Z

tests/integration/operatorhub/cmd_service_test.go

 		// TODO: remove this when OperatorHub integration is fully baked into odo
-		os.Setenv("ODO_EXPERIMENTAL", "true")
+		helper.CmdShouldPass("odo", "preference", "set", "Experimental", "true")


Preference will clash for each spec. SO you need to overwrite the preference path each time the spec is called. For example

context = helper.CreateNewContext() os.Setenv("GLOBALODOCONFIG", filepath.Join(context, "config.yaml")) helper.CmdShouldPass("odo", "preference", "set", "Experimental", "true")

Make sure you are un setting the environment variable GLOBALODOCONFIG in AfterEach teardown step too

openshift-ci-robot · 2020-05-26T13:59:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

**What type of PR is this?** /kind cleanup /kind failing-test **What does does this PR do / why we need it**: This PR ensures that each test spec for operator hub is run in a separate namespace. This is needed because these tests were written in a stringent fashion which tied the hands while writing additional tests for the feature. This PR should help take the tests out of the "odo test statistics" dashboard. **Which issue(s) this PR fixes**: Fixes #3193 **How to test changes / Special notes to the reviewer**: CI should pass. Specially for Operator Hub tests under `tests/integration/operatorhub`

- Removed the function because it *seemed* to be leading to race conditions - Separating specs for the same reason

We're doing this because parallel run is causing numerous failures in CI and local. In spite of debugging it for some time, we're not able to fix it. However, we're on a deadline because operator hub failures are showing up across the PRs. Hence, for time being, we're making these tests sequential. #3244

amitkrout · 2020-05-27T05:37:40Z

@dharmit As pre our last discussion over slack, can you please revert back the changes and make the spec run in series. Also create another issue for test failure while running operator hub test cases in parallel.

Or i am also fine if you want to keep the refactor you made in this pr, but make sure that these test should run sequentially and ofcourse a separate issue for test failure while running operator hub test cases in parallel.

dharmit · 2020-05-27T06:09:38Z

@dharmit As pre our last discussion over slack, can you please revert back the changes and make the spec run in series. Also create another issue for test failure while running operator hub test cases in parallel.

Or i am also fine if you want to keep the refactor you made in this pr, but make sure that these test should run sequentially and ofcourse a separate issue for test failure while running operator hub test cases in parallel.

I'm going with the second one - keeping the changes in this refactor since that ensures that all specs are run in a separate namespace/project and make the tests run sequentially. And I created the issue #3244 yesterday to track this. 👍

dharmit · 2020-05-27T06:28:23Z

Travis failure in generic, login and component command integration tests looks related to issue in connecting with registry.access.redhat.com:

[oc] 'Running oc with args [oc --request-timeout 5m import-image java:8 --namespace=hrclrkttrn --from=registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift:1.5 --confirm]
[oc] error: tag 1.5 failed: Internal error occurred: received unexpected HTTP status: 503 Service Unavailable
[oc] imagestream.image.openshift.io/java imported with errors
[oc] 
[oc] Name:			java
[oc] Namespace:		hrclrkttrn
[oc] Created:		Less than a second ago
[oc] Labels:			<none>
[oc] Annotations:		openshift.io/image.dockerRepositoryCheck=2020-05-26T15:08:52Z
[oc] Docker Pull Spec:	172.30.1.1:5000/hrclrkttrn/java
[oc] Image Lookup:		local=false
[oc] Unique Images:		0
[oc] Tags:			1
[oc] 
[oc] 8
[oc]   tagged from registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift:1.5
[oc] 
[oc]   ! error: Import failed (InternalError): Internal error occurred: received unexpected HTTP status: 503 Service Unavailable
[oc]       Less than a second ago
[oc] 
[oc] 
Running oc with args [oc annotate istag/java:8 --namespace=hrclrkttrn tags=builder --overwrite]
[oc] Error from server (NotFound): imagestreamtags.image.openshift.io "java:8" not found
Deleting project: hrclrkttrn
Running odo with args [odo project delete hrclrkttrn -f]
[odo] I0526 15:08:53.106541    1730 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "hrclrkttrn": no RBAC policy matched
[odo]  ✓  Deleted project : hrclrkttrn
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0526 15:08:53.120594    1730 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Setting current dir to: /home/travis/gopath/src/github.com/openshift/odo/tests/integration
Deleting dir: /tmp/327560218
• Failure [2.306 seconds]
odo component command tests
/home/travis/gopath/src/github.com/openshift/odo/tests/integration/cmd_cmp_test.go:13
  Creating component using symlink
  /home/travis/gopath/src/github.com/openshift/odo/tests/integration/component.go:782
    Should be able to deploy a spring boot uberjar file using symlinks in all odo commands [It]
    /home/travis/gopath/src/github.com/openshift/odo/tests/integration/component.go:806
    No future change is possible.  Bailing out early after 0.268s.
    Running oc with args [oc annotate istag/java:8 --namespace=hrclrkttrn tags=builder --overwrite]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /home/travis/gopath/src/github.com/openshift/odo/tests/helper/helper_run.go:34

Travis failure in devfile catalog, create, push, delete, registry and docker devfile url command integration tests looks related to issue in executing the devrun command:

✓  Executing devbuild command "/artifacts/bin/build-container-full.sh" [53s]
[odo] I0526 15:16:34.369462    7091 adapter.go:354] Executing devfile command devrun
[odo]  •  Executing devrun command "/artifacts/bin/start-server.sh"  ...
[odo] I0526 15:16:34.369549    7091 exec.go:24] Executing command [/opt/odo/bin/supervisord ctl stop all] for pod: obopol-6fdf64bcc9-zx6tt in container: runtime
[odo]  ✗  
[odo] Unable to exec command [/opt/odo/bin/supervisord ctl stop all]: 
[odo] 
[odo]  ✗  Executing devrun command "/artifacts/bin/start-server.sh" [7ms]
[odo]  ✗  Failed to start component with name obopol.
[odo] Error: Failed to create the component: unable to execute the run command: error while streaming command: error sending request: Post https://127.0.0.1:8443/api/v1/namespaces/fdwuwerrac/pods/obopol-6fdf64bcc9-zx6tt/exec?command=%2Fopt%2Fodo%2Fbin%2Fsupervisord&command=ctl&command=stop&command=all&container=runtime&stderr=true&stdout=true: read tcp 127.0.0.1:45876->127.0.0.1:8443: read: connection reset by peer
Deleting project: fdwuwerrac
Running odo with args [odo project delete fdwuwerrac -f]
[odo]  ✗  The project fdwuwerrac does not exist. Please check the list of projects using `odo project list`
• Failure [65.081 seconds]
odo devfile push command tests
/home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:16
  Verify devfile push works
  /home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:49
    should execute the default devbuild and devrun commands if present [It]
    /home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:167
    No future change is possible.  Bailing out early after 60.602s.
    Running odo with args [odo push --devfile devfile.yaml --project fdwuwerrac]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

4.2 and 4.5 integration test failures seem like a flake that's being tracked in #2641.

dharmit · 2020-05-27T06:29:09Z

/test v4.5-integration-e2e
/test v4.2-integration-e2e

amitkrout · 2020-05-27T08:12:50Z

Applying on basis of https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_odo/3239/pull-ci-openshift-odo-master-v4.4-integration-e2e/699/artifacts/integration-e2e/container-logs/test.log
/lgtm

openshift-bot · 2020-05-27T08:38:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-27T08:51:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

codecov · 2020-05-27T10:52:26Z

Codecov Report

Merging #3239 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3239   +/-   ##
=======================================
  Coverage   45.46%   45.46%           
=======================================
  Files         110      110           
  Lines       10814    10814           
=======================================
  Hits         4917     4917           
  Misses       5424     5424           
  Partials      473      473

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2b779...488d66f. Read the comment docs.

…oper#3239) * Modify operator hub tests to run in separate namespaces **What type of PR is this?** /kind cleanup /kind failing-test **What does does this PR do / why we need it**: This PR ensures that each test spec for operator hub is run in a separate namespace. This is needed because these tests were written in a stringent fashion which tied the hands while writing additional tests for the feature. This PR should help take the tests out of the "odo test statistics" dashboard. **Which issue(s) this PR fixes**: Fixes redhat-developer#3193 **How to test changes / Special notes to the reviewer**: CI should pass. Specially for Operator Hub tests under `tests/integration/operatorhub` * Changes as per PR review * Remove createEtcdClusterService function and more separate specs - Removed the function because it *seemed* to be leading to race conditions - Separating specs for the same reason * Loop for two operators * Make operator hub tests sequential We're doing this because parallel run is causing numerous failures in CI and local. In spite of debugging it for some time, we're not able to fix it. However, we're on a deadline because operator hub failures are showing up across the PRs. Hence, for time being, we're making these tests sequential. redhat-developer#3244

@cdrage

* add mik-dass and dharmit as top level approvers (redhat-developer#3189) * Add .gitignore files for jekyll / site (redhat-developer#3171) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind code-refactoring **What does does this PR do / why we need it**: Updates the `.gitignore` for html and jekyll information. As I kept having to `git clean` the dir. **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Performance improvement for odo catalog list components when using devfiles (redhat-developer#3112) * feat: parallel fetching of component types to improve performance Fix redhat-developer#3105 as we now also fetch devfiles for completion, which was previously prohibitively slow. * fix: add missing mutex, rename existing one for clarity * refactor: simplify getDevfileWith by computing link within function * docs: add documentation, update existing one * refactor: rename wg to devfileWG for clarity * fix: improper test setup * fix: only filter components if there's no error * fix: re-implement using channels, handle error and timeout better * fix: no need to pass error * fix: populate base in GetDevfileIndex, use registry URL, hiding path * fix: properly retrieve all devfiles Performance is not that great so investigating better options. * fix: use new ConcurrentTasks support, allowing proper error reporting * fix: adapt to dynamic registries * feat: simplify ConcurrentTask by hiding WaitGroup It was too easy to forget calling Done in ToRun leading to deadlocks. * fix: broken tests * fix: wording [skip ci] * fix: remove unused function, added doc [skip ci] * fix: remove unused ErrorWrapper [skip ci] * fix: rename package import [skip ci] * fix: test getDevfileIndexEntries directly, remove now unused function * JSON output for service list in experimental mode (redhat-developer#3186) * JSON output for service list in experimental mode * Changes to tests as per PR feedback redhat-developer#3186 (review) * Adds a document for debugging applications using devfiles (redhat-developer#3187) * Adds a document for debugging applications using devfiles * Updated syntax and improving the wording Signed-off-by: mik-dass <mrinald7@gmail.com> * Actually wait for the project to be deleted.. (redhat-developer#2397) Actually wait.. Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Run devfile docker url tests without kube config (redhat-developer#3223) * Run devfile docker url tests without kube config Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update target Signed-off-by: John Collier <John.J.Collier@ibm.com> * Fix typo Signed-off-by: John Collier <John.J.Collier@ibm.com> * Setting golang version uniformly accross repo and updating docs (redhat-developer#3204) * Setting golang version uniformly accross repo and updating docs - All golang version references now uniformly updated to 1.12 - Adding all golang version references to development.adoc Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding golang warning to admonition block Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unnessasary space Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding back warning as github does not render admonition in normal view Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing the warning to look better Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing up the list title Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing up admonishments Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing commits as per @cdrage comments Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fix odo describe not listing all the ports after first url is created (redhat-developer#3224) * Fix odo describe not listing all the ports after first url is created This PR fixes redhat-developer#3201. Signed-off-by: Denis Golovin dgolovin@redhat.com * update tests Co-authored-by: Tomas Kral <tkral@redhat.com> * Support listing devfile components with no devBuild command (redhat-developer#3172) * Don't require devfiles to have a devBuild command Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update integration tests Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update integration test Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update integration test for odo create Signed-off-by: John Collier <John.J.Collier@ibm.com> * Make devRun check case-insensitive Signed-off-by: John Collier <John.J.Collier@ibm.com> * replace secured with secure (redhat-developer#3238) A typo existing in sample file * Running devfile integration tests on kubernetes cluster (redhat-developer#3233) * Document to run tests on kubernetes cluster * Addressed review comment * Updated the doc as per reviewer request * Modify operator hub tests to run in separate namespaces (redhat-developer#3239) * Modify operator hub tests to run in separate namespaces **What type of PR is this?** /kind cleanup /kind failing-test **What does does this PR do / why we need it**: This PR ensures that each test spec for operator hub is run in a separate namespace. This is needed because these tests were written in a stringent fashion which tied the hands while writing additional tests for the feature. This PR should help take the tests out of the "odo test statistics" dashboard. **Which issue(s) this PR fixes**: Fixes redhat-developer#3193 **How to test changes / Special notes to the reviewer**: CI should pass. Specially for Operator Hub tests under `tests/integration/operatorhub` * Changes as per PR review * Remove createEtcdClusterService function and more separate specs - Removed the function because it *seemed* to be leading to race conditions - Separating specs for the same reason * Loop for two operators * Make operator hub tests sequential We're doing this because parallel run is causing numerous failures in CI and local. In spite of debugging it for some time, we're not able to fix it. However, we're on a deadline because operator hub failures are showing up across the PRs. Hence, for time being, we're making these tests sequential. redhat-developer#3244 * Add devfile command flags to watch (redhat-developer#3075) * save non default devfile cmd in env.yaml for push and watch Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Add and update tests for envinfo Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Update watch test to incl new watch param Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * watch integration test Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Display msg when devfile commands are changed via odo push Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Change Logic for watch flag + feedback 1 Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Update Watch tests with feedback Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * disable watch test on kube since we now use oc Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Watch test feedback 2 Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Adding sparseCheckoutDir functionality to devfiles (redhat-developer#3042) * Initial commit * added devfile * added tests * commented out tests * change to validpath statement * changed method of extracting zip * changed pathsToUnzip to pathToUnzip * Added error message when no files are unzipped * cleaned up conditional prefix trim * Changes from feedback * feedback changes and unit tests for util func * check for empty pathToUnzip * changed error message format * cleaned up path separator for windows * fixed return pathToUnzip * use hassuffix * moved to function * fromslash * minor fixes * lowercase fix for test * Run test locally against 4.* Cluster (redhat-developer#3218) * Run test locally against 4.* Cluster * Added review comments * Added few more review comments * Addressed review comments * Addressed review comments * Addressed correct format review comments * Update samples for deploying a devfile in deploying-a-devfile-using-odo.adoc (redhat-developer#3163) * Update devfile doc samples [skip ci] Signed-off-by: John Collier <John.J.Collier@ibm.com> * Address review comments Signed-off-by: John Collier <John.J.Collier@ibm.com> * Fix formatting Signed-off-by: John Collier <John.J.Collier@ibm.com> * Replace multiple expect statement with MatchAllInOutput and DontMatchAllInOutput (redhat-developer#3251) * Replaced multiple expect assert statement with MatchAllInOutput * Replaced multiple expect check within same variable with MatchAllInOutput and DontMatchAllInOutput throughout the test * Formatted string array which were exceeding 120 character * add state to ingress list and describe (redhat-developer#3160) * add state to ingress list and describe Signed-off-by: Stephanie <stephanie.cao@ibm.com> * use URL struct in url describe and list * add unit tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * modify integration test and add more unit tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * remove types created * address review comment * delete removed tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * return error if the error is not notfound Signed-off-by: Stephanie <stephanie.cao@ibm.com> * list multiple ulrs in test Signed-off-by: Stephanie <stephanie.cao@ibm.com> * Don't prompt for namespace if pushtarget is Docker (redhat-developer#3248) Signed-off-by: John Collier <John.J.Collier@ibm.com> * Fix windows incompatibility with /tmp (redhat-developer#3252) * Fix checkForImageStream to return correct result. (redhat-developer#3281) * Add Support for Devfile V2 (redhat-developer#3216) * Add Devfile Parser V2, Update Common Structs (redhat-developer#3188) * Add Devfile Parser for Version 2.0.0 Added Devfile V2 Go Structures Added converter for v2 ro common types Signed-off-by: adisky <adsharma@redhat.com> * Add example V2 devfile added example nodejs V2 devfile * Add Common Types as V2 Add common types as v2 Add Converter from common to v1 * Updated example devfile with group * Fixes command.go and kubernetes adapter (redhat-developer#3194) Signed-off-by: mik-dass <mrinald7@gmail.com> * Fixes utils of k8s adapter (redhat-developer#3195) * Update Command Logic to use groups (redhat-developer#3196) * Updates create logic to v2 (redhat-developer#3200) * Fixes utils of docker docker adapter (redhat-developer#3198) Signed-off-by: mik-dass <mrinald7@gmail.com> * Update Docker and Kubernetes adapter to use groups (redhat-developer#3206) * Update Docker and Kubernetes adapter to use groups * Update Some Validation Incorporate some review comments for commands Map Update Some Validation logic * Updated Logs for V2 (redhat-developer#3208) Fixed interface implementation for v2 Updated logs refactored commands.go * Avoid String Pointers (redhat-developer#3209) While converting v1 to v2 types, string pointers are prone to cause null pointer error. This PR updates struct fields from string pointers to string * Update commands check * Fixes lower and upper case for commands (redhat-developer#3219) * Fixes type of project and components for devfile v1 (redhat-developer#3228) * Update testing utils (redhat-developer#3220) * Update command tests Updated Command tests to v2 Removed some cases like command type validation, that will be validated by schema only. * Fix common adapters tests All devfile.adapters.common unit tests are fixed * Add tests for Mismatched type Fix devfile.adapters.Kubernetes.Component unit tests * Add TestCase for default command * Design proposal: Event notification support for build and application status for IDE integration for devfile scenarios (redhat-developer#2550) (redhat-developer#3177) * Add event notification proposal [skip ci] * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Fix Integration tests for devfile v2 (redhat-developer#3236) * Fix Integration tests Correct volume structure Fix supervisord binary insertion for docker Insert command and args in build container fr docker * Fix Integration tests Revert commands, args removal Add commands, args in v2 common structs Fix duplicate volume error * Fixes unit tests (redhat-developer#3240) Signed-off-by: mik-dass <mrinald7@gmail.com> * Add devfiles V2 examples (redhat-developer#3253) Add devfiles v2 examples for springboot and nodejs * Fix regression by sparse checkout dir PR (redhat-developer#3258) fix regression caused by rebase to master. Also add github, zip as supported project types. * Address review comments (redhat-developer#3267) * Address review comments part 2 fix log levels to v4 fix error formatting add case no's in test cases update some comments * Address review comments part 2 Remove validation for group Co-authored-by: Mrinal Das <mrinald7@gmail.com> Co-authored-by: Jonathan West <jgwest@users.noreply.github.com> * devfile push Integration test on kubernetes cluster (redhat-developer#3041) * Running devfile push integration test on kubernetes cluster * Updated xenial insecure registry path * Modifying Runner variable name to cliRunner * Common project Create and Delete function according to the running cluster * Added checks for CI to copy kubeconfig to temp dir * Skipping Kubeconfig set to temporary config file for prow * Set Kubeconfig in temporary config file on kubernetes cluster only * Fixes Kubeconfig code sync * Separate out function for getting cliRunner * Release 1.2.2 of odo (redhat-developer#3294) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Releases 1.2.1 of odo **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Fixes list and describe of secure URLs for not pushed components (redhat-developer#3269) * Don't show imagestreams error on experimental mode (redhat-developer#3265) * Don't show imagestreams error on experimental mode Signed-off-by: John Collier <John.J.Collier@ibm.com> * Remove unnecessary line Signed-off-by: John Collier <John.J.Collier@ibm.com> * Move where error message printed Signed-off-by: John Collier <John.J.Collier@ibm.com> * Use %q instead Signed-off-by: John Collier <John.J.Collier@ibm.com> * remove openshift logo from readme (redhat-developer#3301) * Remove unnecessary preference set (redhat-developer#3287) * report error can't find the app (redhat-developer#2927) * Update build/VERSION to 1.2.2 (redhat-developer#3306) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Updates the build version to 1.2.2 **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Update tests to use java-openliberty (redhat-developer#3318) * Removing install script and update other references (redhat-developer#3202) * Removing installer scripts and references in other scripts and readme Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing installer reference from development.adoc Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding a message to installer script so as to not break it for existing users Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unused variable which is no longer needed Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing installer again Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unused secret directory (redhat-developer#3290) * devfile delete Integration test on kubernetes cluster (redhat-developer#2913) * Run devfile delete integration test on kubernetes cluster * Adding insecure registry in Docker configuration xenial ubuntu * Fix namespace issue for url create --now (redhat-developer#3321) * Add --devfile flag support (redhat-developer#3118) * feat: add --devfile flag support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: fix gosec G307 issue Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: update error handling Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * style: Update help and error messages Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: Improve performance of error handling Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * style: Improve error message Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: Fix remove file error on Windows Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: Use existing structure to handle temp file Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * refactor: improve code readability and structure Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * docs: update variable comments Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: --devfile value supports http(s) Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: remove --devfile for all other commands Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: add new design for existing devfile support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: update TestCopyFile test cases Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: refactor file copy util function for test Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix TestCopyFile test cases Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: add integration tests for existing devfile Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: gosec issue Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix docker url integration tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: context support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix docker url integration tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: handle edge cases and add related tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * refactor: separate spinner for existing devfile Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix docker watch tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix url tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Updating travis env variable and adding docker version info (redhat-developer#3068) * 'odo login' command should suggest 'odo project list' instead of 'odo projects' (redhat-developer#3262) * use a more specific error message for when image is not found (redhat-developer#3322) * use a specific error message for when image is not found * added amit's changes * devfile create Interation test on kubernetes cluster using travis CI (redhat-developer#2884) * Run devfile create Interation test on kubernetes cluster * Skipping s2i image related test on kubernetes cluster * Updating url delete to apply `--now` on devfile (redhat-developer#3139) * Creating a function for setting devfile path * updating url delete to do devfile push post delete Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding URL now flag delete test Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing missing `-f` Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Changing position of copyexample Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Merging url delete with now with create Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing old devfilepath logic Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding Devfile flag to url delete Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * CompleteDevfilePath now happens irrespective of now Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * list devfile components catalog in json format (redhat-developer#3264) * list catalog in json format for devfile components Signed-off-by: Stephanie <stephanie.cao@ibm.com> * list devfile registries in list * combined two list into one single list Signed-off-by: Stephanie <stephanie.cao@ibm.com> * add omitempty * Fix unsafe data race in ExecuteCommand (redhat-developer#3310) **What type of PR is this?** /kind bug **What does does this PR do / why we need it**: Fixes a potential flake with regards to when writing to cmdOutput at the same time that log.ErrorF(...) is reading from it. **Which issue(s) this PR fixes**: Closes redhat-developer#2828 **How to test changes / Special notes to the reviewer**: N/A, honestly not too sure * Fix Docker Supervisord Vol Initialization (redhat-developer#3129) * apply stashed supervisord docker changes from PR Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * rebase 1 with master Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Converts v1 devfiles to v2 (redhat-developer#3279) * Converts v1 devfiles to v2 * Moves init tests to devfilesV1 folder * Adding oc to bin path for multistage testing (redhat-developer#3351) * Revert "Adding oc to bin path for multistage testing (redhat-developer#3351)" (redhat-developer#3360) This reverts commit fa9f7b9. * resolved the gosec issue failing unit tests (redhat-developer#3358) * resolved the gosec issue failing unit tests * resolved typo in the comment * DRYed the code * Warn if --app and --all-apps coexist (redhat-developer#2941) * url list routes and ingress (redhat-developer#3305) * list routes and ingress Signed-off-by: Stephanie <stephanie.cao@ibm.com> * add unit tests * add integration tests and describe partially works Signed-off-by: Stephanie <stephanie.cao@ibm.com> * finished unit test and integration for describe urls * address review comments Signed-off-by: Stephanie <stephanie.cao@ibm.com> * add more unit tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix unit test failure Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix integration test failure Signed-off-by: Stephanie <stephanie.cao@ibm.com> * use ownerreference to distinguish real route vs route created from ingress Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix integration test Signed-off-by: Stephanie <stephanie.cao@ibm.com> * address review comment Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix a bug Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix a bug Signed-off-by: Stephanie <stephanie.cao@ibm.com> * also test secure state in url describe and list Signed-off-by: Stephanie <stephanie.cao@ibm.com> * try to avoid G404 error in unit test Signed-off-by: Stephanie <stephanie.cao@ibm.com> * Fix 'odo version' integration test. (redhat-developer#3326) * Validate application exist before describe it (redhat-developer#3349) * Update events (redhat-developer#3370) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind documentation [skip ci] **What does does this PR do / why we need it**: Updates the events to list that they happened in the past **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Updates the v2 schema to the latest (redhat-developer#3352) * fix: properly check that odo version contains the server URL (redhat-developer#3365) * fix: properly check that odo version contains the server URL Fixes redhat-developer#3342 * fix: simplify test by removing server url regexp check * Create periodic script for odo periodic job (redhat-developer#3376) * Adds debug command for devfiles (redhat-developer#3059) * Adds debug command for devfiles * Fixes comments and variable names * Adds devfile debug test on kubernetes cluster * Fixes adapter code for debug Signed-off-by: mik-dass <mrinald7@gmail.com> * Converts v1 debug test devfile to v2 * Moves container arg and command overriding to a new function * Simplifies conditions in test * Modifies execDevfile for kubernetes component adapter * Simplies error checking logic in TestUpdateContainersWithSupervisord * Removes unnecessary else if conditions * Installs socat before running tests on kubernetes cluster * Show error message if no registries are configured (redhat-developer#3339) * Show error message if no registries are configured Signed-off-by: John Collier <John.J.Collier@ibm.com> * Clean up Signed-off-by: John Collier <John.J.Collier@ibm.com> * Added few supported container images to e2e image test (redhat-developer#3315) * Fix multiple registry related issues (redhat-developer#3341) * feat: fix registry issues Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * docs: improve error/help message Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: improve registry tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: github raw url conversion support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: refactor testing output format Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix breaking tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * refactor: add validation for raw url conversion Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Update dependencies in glide.yaml for make to succeed in building odo binary (redhat-developer#3369) * Execute `glide update -v` to update the dependencies * Use ContainerJSON in place of Container struct * Push support: Event notification support for build and application status for IDE integration for devfile scenarios (redhat-developer#3003) * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Remove --devfile * Remove incorrect constraint * Add odo push -o json example * Rebase and add debug action logging to new methods * Adding oc binary to bin path for multi stage test infra (redhat-developer#3362) * Adding oc binary to bin path for multi stage test infra * Added file permission locally and excluding it from docker file * Created different dockerfile to avoid master break and proceed with multistage changes * Update devfile log levels from 3 to 4 to be consistent (redhat-developer#3408) Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Design proposal: secure registry support (redhat-developer#3329) * docs: add secure registry design proposal Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * docs: add create component section Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Add command design for basic auth Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Proposal for odo deploy (redhat-developer#3368) * docs: Initial design proposal for odo deploy command Initial design proposal for adding a odo deply command. This is related to redhat-developer#3300 Signed-off by: Neeraj Laad <neeraj.laad@gmail.com> * Updated future evolution Updated future evolution Signed-off-by: Neeraj Laad <neeraj.laad@gmail.com> * Updates to design Signed-off-by: Neeraj Laad <neeraj.laad@gmail.com> * Update odo-deploy.md * Updated metadata to attributes Updated metadata to attributes * Fixed formatting Fixed formatting for yaml * [skip ci] updated design doc * [skip ci] made credentials flag optional made credentials flag optional * [skip ci] clarify the deplyment example clarify the deplyment example * [skip ci] Updated proposal to sue buildconfig / kaniko * [skip ci] update attribites to metadata * [skip ci] add `alpha.` suffix to metadata keys to indicate this is temporary * [skip ci] Use COMPONENT_NAME as placeholder * Updating script path in Dockerfile for multistage test (redhat-developer#3412) * Invalid ANSI colouring on Windows when doing devfile push (redhat-developer#3327) * show catalog component list -o json as before if experimental mode is off (redhat-developer#3399) Signed-off-by: Stephanie <stephanie.cao@ibm.com> * removed deprecated and nodejs 8 images from e2e tests and README (redhat-developer#3414) * removed deprecated and nodejs 8 images from e2e tests * removed the unsupported images from readme and removed bucharest-gold/centos7-s2i-node from everywhere as the repo has been archived * adjusted the table * Update changelog script (redhat-developer#3421) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind code-refactoring **What does does this PR do / why we need it**: Updates the changelog script since we were having issues with changelog not completing due to hitting the GitHub API limit. **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Release 1.2.3 (redhat-developer#3422) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Release 1.2.3 of odo **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * fix 'Timeout out' typo and fix formatting (redhat-developer#3404) * fix 'Timeout out' typo and fix formating * fix typo * pull changes from upstream master * add wwhrd check execption for knative.dev/pkg/test/... Co-authored-by: Tomas Kral <tkral@redhat.com> Co-authored-by: Charlie Drage <charlie@charliedrage.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com> Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> Co-authored-by: Mrinal Das <mrinald7@gmail.com> Co-authored-by: John Collier <John.J.Collier@ibm.com> Co-authored-by: Mohammed Ahmed <mohammed.zee1000@gmail.com> Co-authored-by: Denis Golovin <dgolovin@users.noreply.github.com> Co-authored-by: ji chen <jichenjc@cn.ibm.com> Co-authored-by: Priti Kumari <pkumari@redhat.com> Co-authored-by: Maysun J Faisal <31771087+maysunfaisal@users.noreply.github.com> Co-authored-by: CameronMcWilliam <Cameron.McWilliam@ibm.com> Co-authored-by: Amit Rout <arout@redhat.com> Co-authored-by: Stephanie Cao <stephanie.cao@ibm.com> Co-authored-by: Zheng Xiao Mei <xmzheng@cn.ibm.com> Co-authored-by: Aditi Sharma <adsharma@redhat.com> Co-authored-by: Jonathan West <jgwest@users.noreply.github.com> Co-authored-by: Jingfu Wang <jingfu.j.wang@ibm.com> Co-authored-by: Devang Gaur <dgaur@redhat.com> Co-authored-by: Girish Ramnani <gramnani@redhat.com> Co-authored-by: Girish Ramnani <girishramnani95@gmail.com> Co-authored-by: Neeraj Laad <neeraj.laad@gmail.com>

openshift-ci-robot added kind/cleanup labels May 22, 2020

openshift-ci-robot requested review from mohammedzee1000 and prietyc123 May 22, 2020 09:29

dharmit mentioned this pull request May 22, 2020

Fix odo describe not listing all the ports after first url is created #3224

Merged

dharmit commented May 22, 2020

View reviewed changes

prietyc123 reviewed May 22, 2020

View reviewed changes

scripts/setup-operators.sh Show resolved Hide resolved

prietyc123 reviewed May 22, 2020

View reviewed changes

scripts/setup-operators.sh Show resolved Hide resolved

prietyc123 suggested changes May 22, 2020

View reviewed changes

tests/integration/operatorhub/cmd_service_test.go Outdated Show resolved Hide resolved

tests/integration/operatorhub/cmd_service_test.go Outdated Show resolved Hide resolved

tests/integration/operatorhub/cmd_service_test.go Outdated Show resolved Hide resolved

openshift-ci-robot assigned prietyc123 May 22, 2020

prietyc123 suggested changes May 22, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 22, 2020

prietyc123 suggested changes May 22, 2020

View reviewed changes

amitkrout suggested changes May 26, 2020

View reviewed changes

openshift-ci-robot assigned amitkrout May 26, 2020

dharmit added 3 commits May 26, 2020 20:14

Changes as per PR review

b118f62

Remove createEtcdClusterService function and more separate specs

b0ff12e

- Removed the function because it *seemed* to be leading to race conditions - Separating specs for the same reason

dharmit added 2 commits May 26, 2020 20:14

Loop for two operators

a683722

dharmit mentioned this pull request May 27, 2020

Prow test are failing due to nodejs-8 image #2641

Closed

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 27, 2020

openshift-merge-robot merged commit 20491af into redhat-developer:master May 27, 2020

dharmit deleted the fix-3193 branch May 27, 2020 11:39

dharmit mentioned this pull request May 29, 2020

Fix #2707 : odo catalog list components -o json does not have imageStreamRef in json output after update from v1.0.x to v1.1.0 #3226

Merged

rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023

Modify operator hub tests to run in separate namespaces #3239

Modify operator hub tests to run in separate namespaces #3239

Conversation

dharmit commented May 22, 2020 • edited Loading

dharmit May 22, 2020 • edited Loading

Choose a reason for hiding this comment

dharmit May 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prietyc123 May 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prietyc123 commented May 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kadel commented May 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharmit commented May 22, 2020

dharmit commented May 22, 2020 • edited Loading

amitkrout commented May 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 26, 2020

amitkrout commented May 27, 2020 • edited Loading

dharmit commented May 27, 2020

dharmit commented May 27, 2020

dharmit commented May 27, 2020

amitkrout commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-bot commented May 27, 2020

codecov bot commented May 27, 2020

Codecov Report

dharmit commented May 22, 2020 •

edited

Loading

dharmit May 22, 2020 •

edited

Loading

dharmit May 22, 2020 •

edited

Loading

prietyc123 May 22, 2020 •

edited

Loading

dharmit commented May 22, 2020 •

edited

Loading

amitkrout commented May 27, 2020 •

edited

Loading